git mergetool listed some candidates for mergetools twice, depending on the environment. Signed-off-by: Johannes Gilger <heipei@xxxxxxxxxxxx> --- This improves on v2 of this patch as it appends non-gui merge-tools even if $DISPLAY is set. It still makes the assumption that KDE_FULL_SESSION and GNOME_DESKTOP_SESSION_ID are never set at the same time. If this were to happen the tool would simply prefer meld over kdiff3. git-mergetool.sh | 18 ++++++++---------- 1 files changed, 8 insertions(+), 10 deletions(-) diff --git a/git-mergetool.sh b/git-mergetool.sh index 00e1337..09f3a10 100755 --- a/git-mergetool.sh +++ b/git-mergetool.sh @@ -390,21 +390,19 @@ fi if test -z "$merge_tool" ; then if test -n "$DISPLAY"; then - merge_tool_candidates="kdiff3 tkdiff xxdiff meld gvimdiff" if test -n "$GNOME_DESKTOP_SESSION_ID" ; then - merge_tool_candidates="meld $merge_tool_candidates" - fi - if test "$KDE_FULL_SESSION" = "true"; then - merge_tool_candidates="kdiff3 $merge_tool_candidates" + merge_tool_candidates="meld kdiff3 tkdiff xxdiff gvimdiff" + else + merge_tool_candidates="kdiff3 tkdiff xxdiff meld gvimdiff" fi fi if echo "${VISUAL:-$EDITOR}" | grep 'emacs' > /dev/null 2>&1; then - merge_tool_candidates="$merge_tool_candidates emerge" - fi - if echo "${VISUAL:-$EDITOR}" | grep 'vim' > /dev/null 2>&1; then - merge_tool_candidates="$merge_tool_candidates vimdiff" + merge_tool_candidates="$merge_tool_candidates emerge opendiff vimdiff" + elif echo "${VISUAL:-$EDITOR}" | grep 'vim' > /dev/null 2>&1; then + merge_tool_candidates="$merge_tool_candidates vimdiff opendiff emerge" + else + merge_tool_candidates="$merge_tool_candidates opendiff emerge vimdiff" fi - merge_tool_candidates="$merge_tool_candidates opendiff emerge vimdiff" echo "merge tool candidates: $merge_tool_candidates" for i in $merge_tool_candidates; do init_merge_tool_path $i -- 1.6.1.40.g8ea6a -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html