Re: [RFC/PATCH v3 2/3] sha1_file: prepare for adding alternates on demand

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, 23 Jan 2009, Lars Hjemli wrote:

> On Fri, Jan 23, 2009 at 00:43, Johannes Schindelin
> <Johannes.Schindelin@xxxxxx> wrote:
> > On Thu, 22 Jan 2009, Lars Hjemli wrote:
> >> +             if (!quiet)
> >> +                     error("object directory %s does not exist; "
> >> +                           "check .git/objects/info/alternates.",
> >> +                           ent->base);
> >
> > FWIW my concern is not at all addressed.  A future user of add_alt_odb()
> > (and possibly your users in rare cases, too) can trigger the error that
> > suggests looking into the alternates.  Leaving the human user puzzled.
> 
> Is it the phrasing of the error message that concerns you (when
> invoked from add_alt_odb())?
> 
> If so, would something like this be ok/better?
> 
> >> +             if (!quiet)
> >> +                     error("Alternate object directory %s does not exist ",
> >> +                           ent->base);

That would almost certainly be better.

Ciao,
Dscho

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux