On Fri, Jan 23, 2009 at 00:44, Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: > On Thu, 22 Jan 2009, Lars Hjemli wrote: > >> The new --submodules option is used to trigger inclusion of checked out >> submodules in the archive. >> >> The implementation currently does not verify that the submodule has been >> registered as 'interesting' in .git/config, neither does it resolve the >> currently checked out submodule HEAD but instead uses the commit SHA1 >> recorded in the gitlink entry to identify the submodule root tree. > > Please understand that I skipped the rest of the patch. That's too bad, I hoped on some feedback from you on the part of the commit message which you didn't quote: >> The plan is to fix these limitations by extending --submodules to allow >> certain flags/options: >> a|c|r include any|checked out|registered submodules >> H resolve submodule HEAD to decide which tree to include >> g:<name> only include submodules in group <name> >> >> The syntax would then become '--submodules[=[a|c|r][H][g:<name>]]' and >> group membership could be specified in .git/config and/or .gitmodules. >> The current behavior would then match '--submodules=c' (which might be a >> sensible default when only --submodules is specified). Wouldn't such an option address your concern about the consistency/semantics of the --submodules operation? -- larsh -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
