I know that this and the other patch I sent are completely trivial and uninteresting, but they would appear to be correct. Do I need to prod more to get them included or what? Did I submit them incorrectly? On Fri, Jan 16, 2009 at 2:22 PM, Stefan Karpinski <stefan.karpinski@xxxxxxxxx> wrote: > > CVS server was running the hook before the update > action was actually done. This performs the update > before the hook is called. > --- > > Unless I'm severely misunderstanding the meaning of > a *post-update* hook, I think this is a no-brainer. > > git-cvsserver.perl | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/git-cvsserver.perl b/git-cvsserver.perl > index c1e09ea..d2e6003 100755 > --- a/git-cvsserver.perl > +++ b/git-cvsserver.perl > @@ -1413,14 +1413,14 @@ sub req_ci > close $pipe || die "bad pipe: $! $?"; > } > > + $updater->update(); > + > ### Then hooks/post-update > $hook = $ENV{GIT_DIR}.'hooks/post-update'; > if (-x $hook) { > system($hook, "refs/heads/$state->{module}"); > } > > - $updater->update(); > - > # foreach file specified on the command line ... > foreach my $filename ( @committedfiles ) > { > -- > 1.6.0.3.3.g08dd8 > -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html