Sverre Rabbelier <srabbelier@xxxxxxxxx> writes: > diff --git a/builtin-clone.c b/builtin-clone.c > index f7e5a7b..d5bba0e 100644 > --- a/builtin-clone.c > +++ b/builtin-clone.c > @@ -522,14 +522,23 @@ int cmd_clone(int argc, const char **argv, const char *prefix) > option_upload_pack); > > refs = transport_get_remote_refs(transport); > - transport_fetch_refs(transport, refs); > + if(refs) > + transport_fetch_refs(transport, refs); Thanks. I think the basic idea is Ok, but is it a reliable check at this point to see if (refs == NULL) to tell if the target repository is an empty one? I am mostly worried about a failure case (connected but couldn't get the refs, or perhaps connection failed to start). If you get a NULL in such a case you may end up saying "oh you cloned a void" when you should say "nah, such a remote repository does not exist". If transport_get_remote_refs() dies without returning NULL, that would be sufficient, but I didn't check. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
