Re: CR codes from git commands

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 22 Jan 2009, Brent Goodrick wrote:

> Mike Ralphson writes:
>  > >2009/1/22 Brent Goodrick <bgoodr@xxxxxxxxx>:
>  > > The environment I'm running git under is the Shell mode inside GNU
>  > > Emacs. I can't tell you what type of terminal it is, because I believe
>  > > that is defined deep in the guts of Emacs. Having read your reply
>  > > above, I'm now wondering whether this is an Emacs issue versus a git
>  > > issue. If it is an Emacs issue, then I am truly embarrassed for having
>  > > wasted everyones time with it.
>  > 
>  > 2009/1/22 Junio C Hamano <gitster@xxxxxxxxx>:
>  > > I think we pay attention to "dumb" when deciding if pager is useful and if
>  > > we can do color, but I do not think we check anything beyond "is it a tty"
>  > > when deciding to show progress or not.  The only thing we do differently
>  > > for "dumb" terminal is if we use ANSI clear-to-eol escape sequence or fill
>  > > with a run of SPs to overwrite trailing part of a line, and we assume even
>  > > dumb terminals know how to do a carriage-return.
>  > 
>  > I think this earlier discussion is probably relevant... I'm guessing
>  > though, $EDITOR is set correctly here 8-)
> 
> I do have EDITOR set to a home-built version of gnuclient, and git
> talks to Emacs by way of that gnuclient just fine when I'm not using the
> -m "commit_message" git-commit option.
> 
>  > 
>  > 2008/12/17 Junio C Hamano <gitster@xxxxxxxxx>:
>  > > Any semi-good emacs users (let alone hackers) export PAGER=cat to be used
>  > > in compilation mode (and possibly shell mode), so this is not a problem in
>  > > practice.
>  > >
>  > > I have something like this in my .emacs:
>  > >
>  > >    (setenv "PAGER" "cat")
>  > >
>  > > I suspect (I am just a user not a hacker) this will have bad interaction
>  > > with emacs terminal emulation mode, but I do not use the mode, so it is
>  > > enough for me.
> 
> I have PAGER set to "cat" in the environment before I run Emacs for
> the same reason.
> 
> Unfortunately, this morning when I rebooted and reloaded from scratch,
> I am now unable to reproduce the CR codes output from "git pull" no
> matter what I do. I even tried the older git installed on Debian Linux
> "testing", and tried unsetting PAGER and GIT_PAGER, and saw the pager
> prompts and the terminal escape sequence output as I expected to
> (which is not the issue here).  I can't expect anyone else to help me
> debug this problem further if I can't even reproduce it
> anymore. Frustrating.
> 
> I do have automatic updates turned on, so perhaps something changed in
> the termcap or how terminal I/O is being done outside of git in my
> system.  Emacs would not have changed since I build Emacs from top of
> trunk CVS, and it only uses local Elisp packages AFAIK.
> 
> I don't suppose git has any logic that emits the progress messages
> based upon some estimate of amount of work it has to do, or has done,
> does it?

It does have logic to only emit progress messages at a reasonable rate 
(otherwise, you might be waiting for the progress messages to be printed 
instead of just waiting for the data to arrive). So it's possible that you 
now have things going fast enough that it only needs to print one message. 
It can also estimate that something hasn't taken long enough for the user 
to get impatient yet, and therefore not show progress at all (so the 
output won't be littered with progress output for every operation that 
could have taken a long time for some data, but didn't for this data).

In any case, it's all done in progress.c, so it should be easy enough to 
make changes to if you can come up with something better to do with 
progress messages and some way to determine when it should be done.

	-Daniel
*This .sig left intentionally blank*
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux