>From bf55fdd37f0fa4d0b3a10f43fa3d1815a6dbc6b3 Mon Sep 17 00:00:00 2001 From: Caleb Cushing <xenoterracide@xxxxxxxxx> Date: Tue, 20 Jan 2009 11:33:30 -0500 Subject: [PATCH] mergetool merge/skip/abort add functionality to skip merging a file or abort from mergetool --- git-mergetool.sh | 20 ++++++++++++++++++-- 1 files changed, 18 insertions(+), 2 deletions(-) diff --git a/git-mergetool.sh b/git-mergetool.sh index 00e1337..bd5711e 100755 --- a/git-mergetool.sh +++ b/git-mergetool.sh @@ -177,8 +177,24 @@ merge_file () { describe_file "$local_mode" "local" "$LOCAL" describe_file "$remote_mode" "remote" "$REMOTE" if "$prompt" = true; then - printf "Hit return to start merge resolution tool (%s): " "$merge_tool" - read ans + while true; do + printf "Use (m)erge file or (s)kip file, or (a)bort? (%s): " \ + "$merge_tool" + read ans + case "$ans" in + [mM]*|"") + break + ;; + [sS]*) + cleanup_temp_files + return 0 + ;; + [aA]*) + cleanup_temp_files + exit 0 + ;; + esac + done fi case "$merge_tool" in -- 1.6.1 > This looks to me like no merge will happen if --no-prompt/-y or > mergetool.prompt is set to false. Have you tested with this option or > have I misread? just tested and it works fine... meaning it doesn't prompt which is what it's supposed to do. > Also, I think you've lost some tabs. Mergetool does have some > inconsistent tabbing but they way I've been aiming towards (which > matches most, but not all of git-mergetool.sh) is to use tabs == 8 > spaces for indents but to indent each level by 4 spaces. e.g. three > levels of indent is one tab plus four spaces. mixing tabs and spaces == bad, I just realized I can't see half your indents because I had tabstop=4 in my vimrc because I like indents at 4 spaces which is what you are doing through emulation. this is why I generally just use tabs or spaces. files like fstab and .sql are my few exceptions, both of which I do more on columns than indents. > I'd like to keep (additionally) the behaviour, that the merge starts > with just pressing <Enter>. Because what you mostly want to do, when > using git-mergetool, is actually merging. done, and maybe you... but generally I've got more skips than merges, but I've got a corner case. -- Caleb Cushing http://xenoterracide.blogspot.com -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html