Re: [PATCH] color-words: Support diff.color-words config option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, 20 Jan 2009, Boyd Stephen Smith Jr. wrote:

> It uses "diff.wordregex" for reasons mention by Dscho and because that 
> was already what the diff drivers were using.

To be fair, Jakub and Junio mentioned it, too.

> I'm not entirely satisfied with it.  There should probably be some way 
> to force the default behavior (which is a bit faster) even if a global 
> config or diff driver exists.  Also, I think camelCase is better than 
> runtogether so I'd prefer to change "wordregex" -> "wordRegex" across 
> the entire patch set.

Well, the thing is, it _should_ be "wordRegex", _except_ in the strcmp() 
because the config helpers get a downcased key.

Ciao,
Dscho
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux