Please squash in.
---
On Mon, 19 Jan 2009, Johannes Schindelin wrote:
> @@ -720,7 +718,7 @@ static int grab_nth_branch_switch(unsigned char *osha1, unsigned char *nsha1,
> if (target[len] == '\n' && !strncmp(match, target, len))
> return 0;
This code is still not valid, as target[len] can be well after the
NUL marker.
Found by valgrind.
sha1_name.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sha1_name.c b/sha1_name.c
index 4d10705..803f9d2 100644
--- a/sha1_name.c
+++ b/sha1_name.c
@@ -735,7 +735,7 @@ static int grab_nth_branch_switch(unsigned char *osha1, unsigned char *nsha1,
if ((target = strstr(match, " to ")) != NULL) {
len = target - match;
target += 4;
- if (target[len] == '\n' && !strncmp(match, target, len))
+ if (len == strlen(target) && !strncmp(match, target, len))
return 0;
}
else
--
1.6.1.243.g6c8bb35
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
