Hi, On Tue, 20 Jan 2009, Boyd Stephen Smith Jr. wrote: > You are up too late Dscho. You, sir, are absolutely correct. > >Let's squash the two, okay? > > Will do. I expected the code changes to be larger than the test, and > when I finished it was completely the other way. My next patch will be > all-in-one. FWIW I think it is the correct thing to start with the test script, so that you get a better idea what to look out for. And for patches of which I don't know if they are still necessary, I like to "git checkout <name>^ && make -j50 && git checkout <name> && (cd t && sh <test>)". But for submission, I think it makes sense to squash them, except if you submit a bug report with a test script to show the validity of the report first, and only later decide that you want to fix it yourself. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
