On Mon, Jan 19, 2009 at 3:41 PM, Markus Heidelberg <markus.heidelberg@xxxxxx> wrote: > When interrupting git-difftool with Ctrl-C, the output of this echo > command led to having the cursor at the beginning of the line below the > shell prompt. > > Signed-off-by: Markus Heidelberg <markus.heidelberg@xxxxxx> > --- > > David, have you intentionally added this 'echo', did it fix > anything for you? I think you're right in that we're better off without the echo. There wasn't really any reason for it to be there. > > contrib/difftool/git-difftool-helper | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/contrib/difftool/git-difftool-helper b/contrib/difftool/git-difftool-helper > index a2eb59b..0c48506 100755 > --- a/contrib/difftool/git-difftool-helper > +++ b/contrib/difftool/git-difftool-helper > @@ -32,7 +32,6 @@ cleanup_temp_files () { > > # This is called when users Ctrl-C out of git-difftool-helper > sigint_handler () { > - echo > cleanup_temp_files > exit 1 > } > -- > 1.6.1.216.g3acd > > -- David -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html