Johannes Sixt <j6t@xxxxxxxx> writes:
> On Sonntag, 18. Januar 2009, Johannes Sixt wrote:
>> On Sonntag, 18. Januar 2009, Steffen Prohaska wrote:
>> > This simplifies the calling code.
>>
>> But it could really be squashed into the previous patch, after fixing...
>>
>> > @@ -23,6 +23,9 @@ const char *system_path(const char *path)
>> >
>> > const char *git_extract_argv0_path(const char *argv0)
>> > {
>> > + if (!argv0 || !*argv0)
>> > + return 0;
>> > +
>> > const char *slash = argv0 + strlen(argv0);
>>
>> ... this declaration after statement.
>
> And we prefer NULL over 0 for the null pointer.
>
> The series is nicely done, thank you! I am using it (the previous round)
> without problems so far. I hope we can get this in RSN.
Thanks, both. I take that as your Ack to the whole series.
I've rebased the series to master, squashed in fixes like the above (there
were others) so that each step can compile. Will queue the result.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
