On Sun, Jan 18, 2009 at 20:00, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Lars Hjemli <hjemli@xxxxxxxxx> writes: > >> I like the idea, but it will require thorough review of all >> read_tree_recursive() consumers. So now we've got three different >> approaches: >> * me: global setting >> * dscho: parameter to read_tree_recursive() >> * you: accept the return value from the callback function >> >> Junio, what would you prefer? > > As usual René has the best taste in designing things ;-) Agreed. I've pushed an updated series using his approach to the lh/traverse-gitlinks branch in git://hjemli.net/pub/git/git (http://hjemli.net/git/git/log/?h=lh/traverse-gitlinks), but without a fix for Dscho's concern about the behaviour in tree.c::traverse_gitlink(). Hopefully I'll get to send a reworked series later tonight. -- larsh -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
