Re: [PATCH/RFC v1 1/1] +5 cases (4 fail), diff whitespace tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 17 Jan 2009, Junio C Hamano wrote:

Hmm.  Are these three supposed to be orthogonal?

The semantics of those 3 flags are not orthogonal, no. Their relationship amongst each other is one of transitive implication:

-w                    implies the other two
-b                    implies --ignore-space-at-eol
--ignore-space-at-eol implies only itself

Therefore, it is never *necessary* to specify more than one of these flags on the command line. However, it is not hard to imagine scenarios where software wrappers around git (e.g. GUIs, etc), generate command lines with more than one of these flags. I thought about it, and it seems unreasonable to make it an error to specify more than one, since a new user might not immediately grasp the way they imply each other. I think Git could and should treat it as a legal case. I contacted Dscho about fixing it, but he is busy so I will submit a fix patch myself.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux