Hi,
On Sun, 18 Jan 2009, Mike Hommey wrote:
> @@ -450,26 +447,8 @@ static struct ref *get_refs_via_curl(struct transport *transport)
> refs_url = xmalloc(strlen(transport->url) + 11);
> sprintf(refs_url, "%s/info/refs", transport->url);
>
> - slot = get_active_slot();
> - slot->results = &results;
> - curl_easy_setopt(slot->curl, CURLOPT_FILE, &buffer);
> - curl_easy_setopt(slot->curl, CURLOPT_WRITEFUNCTION, fwrite_buffer);
> - curl_easy_setopt(slot->curl, CURLOPT_URL, refs_url);
> - curl_easy_setopt(slot->curl, CURLOPT_HTTPHEADER, NULL);
> -
> - if (start_active_slot(slot)) {
> - run_active_slot(slot);
> - if (results.curl_result != CURLE_OK) {
> - strbuf_release(&buffer);
> - if (missing_target(&results))
> - die("%s not found: did you run git update-server-info on the server?", refs_url);
> - else
> - die("%s download error - %s", refs_url, curl_errorstr);
> - }
> - } else {
> - strbuf_release(&buffer);
> - die("Unable to start HTTP request");
> - }
> + if (http_get_strbuf(refs_url, &buffer, HTTP_NO_CACHE) != HTTP_OK)
> + goto cleanup;
Why not die() as the original code?
Ciao,
Dscho
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
