Thomas Rast <trast@xxxxxxxxxxxxxxx> writes: > diff, log and show all take the same diff options. Refactor them from > __git_diff and __git_log into a variable, and complete them in > __git_show too. > > Signed-off-by: Thomas Rast <trast@xxxxxxxxxxxxxxx> > > --- > > Any news on this? > +__git_diff_common_options="--stat --numstat --shortstat --summary > --patch-with-stat --name-only --name-status --color > --no-color --color-words --no-renames --check > --full-index --binary --abbrev --diff-filter= > - --find-copies-harder --pickaxe-all --pickaxe-regex > + --find-copies-harder The changes around pickaxe made me "Huh?". For log pickaxe makes very good sense but for a single diff it doesn't, yet the original seems to have had them only on "git diff" and not on "git log", which feels wrong. Other than that, I think the patch tries to achieve a great thing in the longer term---we do not have to worry about common parts going out of sync between diff and log family of commands. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
