Hi, On Sat, Jan 17, 2009 at 1:23 PM, Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: > Hi, > > On Sat, 17 Jan 2009, Ray Chuan wrote: > >> note: the test needs to chmod the test_repo.git folder so that >> apache/mod_dav can create .DAV folders in it for locking. > > Is this supposed to explain ... > >> @@ -51,17 +51,16 @@ test_expect_success 'clone remote repository' ' >> git clone $HTTPD_URL/test_repo.git test_repo_clone >> ' >> >> -test_expect_failure 'push to remote repository' ' >> +test_expect_success 'push to remote repository' ' >> cd "$ROOT_PATH"/test_repo_clone && >> : >path2 && >> git add path2 && >> test_tick && >> git commit -m path2 && >> - git push && >> - [ -f "$HTTPD_DOCUMENT_ROOT_PATH/test_repo.git/refs/heads/master" ] >> + git push origin master >> ' > > ... this removal? I do not think this is a good change, as it removes > a test that is actually pretty important. i'm sorry for the poor commit message, what i wanted to do was to change the tests to expect success rather than failure. no tests were removed; only their expected outcomes were modified. currently, the pushes fail, so the test 'fails as expected'; now the pushes succeed, so they shouldn't be expecting failed pushes (or anything else). > BTW I do not understand at all what you mean by "we need to chmod". Does > the Apache instance not run with the current user's permissions? i wrote 'we need to chmod', cos i'm not sure what the permissions are required. sorry, i didn't notice that apache was running with the current user's permissions. but i added the note just in case, for users who don't run apache with the current user, so they modify the test appropriately (ie adding a chmod). > Ciao, > Dscho > -- Cheers, Ray Chuan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
