2009/1/15 Markus Heidelberg <markus.heidelberg@xxxxxx>:> Adeodato Simó, 13.01.2009:>> * Boyd Stephen Smith Jr. [Tue, 13 Jan 2009 14:03:11 -0600]:>>>> > On Tuesday 2009 January 13 10:45:18 Shawn O. Pearce wrote:>> > >See [...] how the subject is a niceshort, one>> > >line summary of the module impacted and the change?>>>> > My rule for this is absolutely no more than 80 characters.>>>> My rule for *all* of the commit message is "absolutely no more than 76>> characters". With more than 76, `git log` wraps in a 80-column terminal.>> What about the 50 character limit proposed in the documentation> (git-commit, gittutorial, user-manual)?>> At the beginning I tried to fulfil this limit, but often it's not easy.> So should it be adjusted to a slightly higher value in the documentation> or even split into a recommended limit (e.g. 50) and a recommended> absolute maximum (e.g. 76)? Hmm, the split wouldn't make sense, I think.
The 50 character limit is for the first line, try "git log--pretty=oneline" and it should be obvious why.The rest of the lines can be longer, 72 is another popular choice.
I'm wondering if the default commit-msg hook should have something like:perl -ne '$lim = (50,0,72)[($.>3?3:$.)-1]; chomp; if (length($_) > $lim) { print STDERR "Line $. of commit message exceeded $limcharacters"; exit 1; }' $1
to more forcefully suggest what's in the manual, like the pre-commit hook does.
(I wish I'd had something like this when one of the devs here pushed acommit with a 346-line message,just listing what files he was changing...doh)
-Baz
>> Markus>> --> To unsubscribe from this list: send the line "unsubscribe git" in> the body of a message to majordomo@xxxxxxxxxxxxxxx> More majordomo info at http://vger.kernel.org/majordomo-info.html>��.n��������+%������w��{.n��������n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�m
