Hi, On Fri, 16 Jan 2009, Santi Béjar wrote: > 2009/1/16 Johannes Schindelin <Johannes.Schindelin@xxxxxx>: > > > > Note that this affects creating bundles with --all; I contend that it > > is a good change to add the HEAD, so that cloning from such a bundle > > will give you a current branch. However, I had to fix t5701 as it > > assumed that --all does not imply HEAD. > > From the description I understand that it only affects when the HEAD is > detached, but in t5701 the HEAD is not detached so nothing should be > fixed. The error in t5701 was that it _wanted_ to test a bundle without a HEAD, but it actually created it with --all. That was implying that --all does not mean HEAD, and I disagree with that. > For gc for sure it is a good thing, but I'm not convinced of the others, > as a detached HEAD is a very special thing (temporary and unnamed > branch). So? What does "--all" mean? All branches or what? :-) Seriously, I think that --all should imply HEAD at all times, as the only time when it makes a difference is when you have that unnamed _branch_ that is a detached HEAD. Maybe I would be more amenable to your criticism if you could come up with a scenario where implying HEAD with --all is _wrong_. Ciao, Dscho
