Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:
> On Thu, 15 Jan 2009, Stephan Beyer wrote:
>
>> Stripping out a libified version seemed better to me than
>> copy and paste.
>
> Oh, definitely.
>
>> - ret = start_command(&hook);
>> - if (ret) {
>> - warning("Could not spawn %s", argv[0]);
>> - return ret;
>> - }
>> - ret = finish_command(&hook);
>> - if (ret == -ERR_RUN_COMMAND_WAITPID_SIGNAL)
>> - warning("%s exited due to uncaught signal", argv[0]);
>
> What are the side effects of replacing this with "ret =
> run_command(&hook);"? This has to be discussed and defended in the commit
> message.
I think the answer is "Lost warnings here and there".
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
