ted@xxxxxxxxxxxxx wrote: > From: Ted Pavlic <ted@xxxxxxxxxxxxx> > > Adds a few simple comments above commands that take arguments. These > comments are meant to remind developers of potential problems that can > occur when the script is sourced on systems with "set -u." Any > function which "requires" arguments really ought to be called with > explicit arguments given. > > Also adds a #!bash to the top of bash completions so that editing > software can always identify that the file is of sh type. > > Signed-off-by: Ted Pavlic <ted@xxxxxxxxxxxxx> > Acked-by: Shawn O. Pearce <spearce@xxxxxxxxxxx> Yup, this and also 2/3 look fine. But again, the message, it shouldn't be indented. > --- > contrib/completion/git-completion.bash | 15 +++++++++++++++ > 1 files changed, 15 insertions(+), 0 deletions(-) -- Shawn. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html