On Wed, Jan 14, 2009 at 05:04:44PM +0100, Michael J Gruber wrote: > It was a lame attempt at getting around it, it's just one line... I > didn't know I've been being noticed long enough ;) > So, should I prepare a series like: > > 1: test case and mark known fail > 2: the 1 line fix > 3: mark test pass > > Or should 2+3 be squashed into one? Definitely the fix and marking the test as passing should be one patch, since then you see that it is the fix which causes the test to pass. But really, for a simple fix I usually just squash it all into a single patch. Then somebody looking at the patch later says "Oh, this is what was broken, and here is how it was fixed." -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
