On Wed, Jan 14, 2009 at 04:40:42PM +0100, Johannes Schindelin wrote: > > Both versions have the same functionality. This removes any > > redundancy. > > > > This also adds makes two extensions to match_pathspec: > > s/makes// Thanks. > Nice. Does it still pass the test suite? (From my reading, it should, > but I do not quite have the time to run it right now.) It sure does. I am not confident enough to send untested patches yet. :-) On Wed, Jan 14, 2009 at 04:44:36PM +0100, Johannes Schindelin wrote: > I would prefer something like this: > > static int has_special(const char *p) > { > while (*p) > if (isspecial(*(p++))) > return 1; > return 0; > } Ok, no problem. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html