Hi, On Wed, 14 Jan 2009, Clemens Buchacher wrote: > @@ -25,6 +25,17 @@ static int default_show_root = 1; > static const char *fmt_patch_subject_prefix = "PATCH"; > static const char *fmt_pretty; > > +static int has_special(const char *p) > +{ > + int x; > + > + while ((x = *p++) != '\0') > + if (isspecial(x)) > + return 1; > + > + return 0; > +} I would prefer something like this: static int has_special(const char *p) { while (*p) if (isspecial(*(p++))) return 1; return 0; } but that is probably a matter of taste. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html