Hi, On Tue, 13 Jan 2009, Junio C Hamano wrote: > Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > > > On Tue, 13 Jan 2009, Tor Arne Vestbø wrote: > > > >> The line length was read from the same position every time, > >> causing mangled output when printing notes with multiple lines. > >> > >> Also, adding new-line manually for each line ensures that we > >> get a new-line between commits, matching git-log for commits > >> without notes. > >> > >> Signed-off-by: Tor Arne Vestbø <tavestbo@xxxxxxxxxxxxx> > >> --- > > > > Patch looks good, so > > > > Acked-by: Johannes Schindelin <johannes.schindelin@xxxxxx> > > > > For extra browny points, you could add a test with multi-line notes. > > Yeah, not just "extra", having tests is a good way to make sure a new > feature like this evolves healthily. Oh, and of course I meant "brownie"... Ducks, Dscho
