Hi, On Tue, 13 Jan 2009, Shawn O. Pearce wrote: > Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: > > On Wed, 14 Jan 2009, Felipe Contreras wrote: > > > > > "S_IFREG | mode" probably is only required for 0644 and 0755. > > > > Why should we want to have that patch? IOW what does it fix, and what > > might it break? > > It cleans up the code to make it more readable. > > It makes no sense to be doing S_IFREG | S_IFLINK, which happens when > the input is for a symlink. It doesn't break anything to do that | > operation, but it also looks damn odd when reading the function. Imagining myself reading the commit message 6 months from now, in all likeliness I will have wished that those two paragraphs were in there. Verbatim. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
