"Shawn O. Pearce" <spearce@xxxxxxxxxxx> wrote > Robin Rosenberg <robin.rosenberg@xxxxxxxxxx> wrote: > > torsdag 08 januari 2009 04:10:05 skrev Ryan Alberts: > > > I have attached a small fix for when a git config has /r lines in the file. > > > I have to admit that I do not usually submit patches to the open source > > > community and I am not very familiar with the process :-) Please, please, > > > let me know if I can do something different next time! > > > > Back to the patch. I think we should only ignore \r (not /r, but could say CR in > > a comment) before an LF. > > I disagree; ignoring CR anyplace in the file should be fine, unless > it is within a double quoted value, in which case it should use > the same rule that \n would use within the same region. > > ' ', \n, \t all act the same with regards to being (mostly) ignored > whitespace. \r is no different. Especially for anyone crazy enough > to still be using a Mac style formatted file, with only CRs in it. Those are copied from in to out in the repo config parser today. Why should ' \r' be treated differently? Just CR (FF, Ctrl-G etc) is garbage, but CRLF is a well established line terminator. -- robin -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
