Re: [JGIT] Blame functionality for jgit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Manuel Woelker <manuel.woelker@xxxxxxxxx> wrote:
> On Mon, Jan 12, 2009 at 6:42 PM, Shawn O. Pearce <spearce@xxxxxxxxxxx> wrote:
> 
> That sounds like a good plan. For now I am not all that concerned
> about performance myself (premature optimization and all that), but in
> the long run - and especially with rename/copy detection that will
> definitely a factor for usability.

Yea, I know.  Premature optimization is the root of all evil.
But we've also learned the hard way that Java is slow as snot
compared to C git.  The only way we can even stay close is to
optimize the hell out of the tight inner sections, and very often
that means using byte[] and avoiding upconverting to String to as
late as we possibly can.

Performance *is* a feature in Git.  Its not a "nice to have",
its a requirement.  The old history view for example was too damn
slow using Commit, requiring minutes on one of my systems to render
egit.git history.  Using RevCommit its subsecond response time.

I just wanted to point out that we care quite a bit about speed, and
that given our input (raw byte[] from the pack) we need to be able
to quickly make decisions without upconverting to String, otherwise
blame performance will be so bad that its completely unusable.

> > I think eventually we'll have a BSD licensed LCS [...]
> 
> While trying to look up the Myers diff algorithm I found a diff
> implementation in Apache wicket (cf.
> http://wicket.sourceforge.net/apidocs/wicket/util/diff/myers/package-summary.html
> ). This one is under an Apache license, is that any better? It's truly
> kind of sad that you need a degree in law these days to get any work
> done in this license jungle. I just happen to strongly oppose the
> reinvention of circular transportation-enabling devices...

Yea, even the ASF has trouble deciding if the Apache License and
the GPL can get along:

  "The Apache Software Foundation is still trying to determine if
  this version of the Apache License is compatible with the GPL."

  http://www.apache.org/licenses/

The Apache License doesn't play nice with GPLv2 apparently, but is
OK with GPLv2, at least according to the FSF.

Anyway.  The Apache License is roughly the new style BSD, but with
patent protection clauses built in.  I think we can consume code
under the Apache License and redistribute it without any trouble
for us, our any of our downstream consumers.

> I'll keep you posted on new developments

Looking forward to it.

-- 
Shawn.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux