Re: [RFC PATCH 4/3] Add example git-vcs-p4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 12 Jan 2009, Alex Riesen wrote:

> 2009/1/11 Daniel Barkalow <barkalow@xxxxxxxxxxxx>:
> > diff --git a/Makefile b/Makefile
> >
> > +LIB_OBJS += p4client.o
> > +LIB_OBJS += vcs-p4.o
> > +
> >
> > +extern int cmd_p4(int argc, const char **argv, const char *prefix);
> > +
> 
> Why is your foreign VCS importer built-in? The majority wont ever need it,
> yet they have to pay the price for its text being in git executable.

Purely for convenience in the RFC version. The real one will probably need 
to be linked separately, since it will want to have the option of using 
the terrible C++ API to the 
closed-source-but-you-can-download-it-from-them library.

	-Daniel
*This .sig left intentionally blank*
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux