Re: [RFC PATCH 4/3] Add example git-vcs-p4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Daniel Barkalow <barkalow@xxxxxxxxxxxx> writes:

>> vcs-p4.c:504: warning: ISO C90 forbids mixed declarations and code
>> make: *** [vcs-p4.o] Error 1
>
> I haven't been over the 4/3 stuff for coding style yet. But how do you get 
> these warnings?

I thought I have mentioned this already, but...

I compile with (at least) these:

    -Wno-pointer-to-int-cast
    -Wold-style-definition
    -Wdeclaration-after-statement

explicitly specified.

I also run kernel's checkpatch.pl script (but ignoring "more than 80-col
is too long" rule) from time to time.

I consider these are good ways to check style-discipline.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux