Re: [PATCH 0/4] refactor the --color-words to make it more hackable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Schindelin wrote:
> 
> But at least _I_ think it is easy to follow, and it actually makes the code
> more readable/hackable.  Correct me if I'm wrong.

It indeed seems a sane approach.  However, the final result segfaults
and/or prints garbage (on apparently every commit except very small
changes) when using the regex '\S+', which IMHO should give exactly
the same result as not using a regex at all.  In git.git:

  $ ./git-show --color-words='\S+' 7eb5bbdb645
  Segmentation fault
  $ ./git-show --color-words='\S+' d3240d935c4
  [...garbled output...]
  Segmentation fault

Plain --color-words is not affected.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch


Attachment: signature.asc
Description: This is a digitally signed message part.


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux