Hi,
On Sun, 11 Jan 2009, Thomas Rast wrote:
> +/* unused right now */
> +enum diff_word_boundaries {
> + DIFF_WORD_UNDEF,
> + DIFF_WORD_BODY,
> + DIFF_WORD_END,
> + DIFF_WORD_SPACE,
> + DIFF_WORD_SKIP
> +};
> +
Just to illustrate why I reacted so harshly to this patch series: this
change is utterly useless.
You do not use the word boundaries at all throughout the complete patch.
This would have been the only way you could have possibly illustrated how
the enum is to be used at all, given that you did not document what the
enum should do eventually.
With such a patch that leaves me as clueless as to the way you want to fix
the issues as before, I regret having spent the time to look at it at all.
What you _should_ have done:
- _not_ introduce the regex. That is not what the first patch should be
about.
- _use_ the enum for the existing functionality.
- _explain_ what the different values of the enum are about.
- _say_ what the enum pointer points at (is it a single value? an array?
if it is an array, is it per letter? per word?)
If you are honest, you'll admit that this patch would leave you puzzled
_yourself_, 6 months from now.
FWIW I think I have a better patch series, to be sent in a few minutes.
Ciao,
Dscho
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
