On Fri, Jan 09, 2009 at 11:36:41AM +0100, Johannes Sixt wrote: > I'll test your other patch (that replaces the execvp in git.c by > run_command). There is something funny with it that I have not diagnosed: aliases are broken, and "git foobar" does not return an error. Presumably just checking the "we did not exec succesfully" case is not triggering properly. However, I think the right solution is actually to refactor git.c to figure out ahead of time whether we have a builtin, external, or alias. I can work on that, but not tonight, as my git-time is up for now. But other than that, did it work for you on Windows? However, here is a 4-patch series that handles the separate signal delivery problem. It should fix the "^C makes funny things happen" problems you were seeing. Please test and let me know how it works on Windows. The patches are: 1/4: Makefile: clean up TEST_PROGRAMS definition 2/4: chain kill signals for cleanup functions 3/4: refactor signal handling for cleanup functions 4/4: pager: do wait_for_pager on signal death -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
