Re: [PATCH 3/6] Glean libexec path from argv[0] for git-upload-pack and git-receive-pack.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Sat, 10 Jan 2009, Steffen Prohaska wrote:

> From: Steve Haslam <shaslam@xxxxxxxxxxxxxx>
> 
> If the user specified the full path to git-upload-pack as the -u option to
> "git clone" when cloning a remote repository, and git was not on the default
> PATH on the remote machine, git-upload-pack was failing to exec
> git-pack-objects.
> 
> By making the argv[0] path (if any) available to setup_path(), this will
> allow finding the "git" executable in the same directory as
> "git-upload-pack". The default built in to exec_cmd.c is to look for "git"
> in the ".../libexec/git-core" directory, but it is not installed there (any
> longer).
> 
> Much the same applies to invoking git-receive-pack from a non-PATH location
> using the "--exec" argument to "git push".
> 
> [ spr: split Steve's original commit into two commits. ]

I think you do not want to have that [ ... ] in the commit message, but 
after the "--".

Further, it would make sense to have these 2 patches independently, 
provided that a test is added with which we could verify that the patches 
are actually necessary for upload-pack/receive-pack.

Logically, and to avoid committing a broken revision, 1/6 should come 
last, methinks.

Ciao,
Dscho

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux