Jeff King wrote:
when sending patch files via git send-email, the perl script assumes
7bit characters only. If there are other bytes in the body (foreign language
characters in names or translations), some servers (like vger.kernel.org)
reject the mail because of th?t. This patch always adds an 8bit header line
to each mail.
This should be done already by git-format-patch when you generate the
patch to feed to send-email.
Well, this could be discussed, after all the problem lies in the actual
transportation, which should be the responsibility of git-send-email.
But I am OK with putting this into format-patch.
> What exactly is the workflow you use to generate this problem?
I use git format-patch to generate a patch file for a single-mail patch
(not a patch series). Then I edit this file manually to add questions
and comments and include my signature. During this step the umlauts came
in. If you have a suggestion to improve this workflow, I am all ears, I
am fairly new to git.
Does it matter where the non-ascii characters are
(commit versus patch, etc)?
Oh, right you are. If there are 8bit characters in the commit message,
git-format-patch adds the appropriate headers.
> What version of git are you using?
Version 1.5.5 on one machine and 1.5.2.2 on another. I know, i know ;-)
but I haven't had time to compile a newer one, yet.
diff --git a/git-send-email.perl b/git-send-email.perl
index 77ca8fe..68a462c 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -793,6 +793,7 @@ To: $to${ccline}
Subject: $subject
Date: $date
Message-Id: $message_id
+Content-Transfer-Encoding: 8bit
X-Mailer: git-send-email $gitversion
";
This fix isn't right anyway. For one thing, if you're going to include
C-T-E, you should also include a MIME-Version header. But more
importantly, we are already handling encoding elsewhere. So
unconditionally adding this means that you may conflict with existing
MIME headers in the @xh variable.
Ok, so what about adding a flag to git-format-patch that forces the 8bit
headers on? I think a workaround would be to add a --subject-prefix with
a special character and later remove this, but this is not really a
long-term solution ;-)
Thanks and regards,
Andre.
--
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
Tel: +49 351 277-84917
----to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Jochen Polster; Thomas M. McCoy; Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
