Hi, On Fri, 9 Jan 2009, Junio C Hamano wrote: > Markus Heidelberg <markus.heidelberg@xxxxxx> writes: > > > When using "git commit" and there was nothing to commit (the editor > > wasn't launched), the status output wasn't colored, even though color.ui > > was set. Only when setting color.status it worked. > > > > Signed-off-by: Markus Heidelberg <markus.heidelberg@xxxxxx> > > --- > > builtin-commit.c | 3 +++ > > 1 files changed, 3 insertions(+), 0 deletions(-) > > > > diff --git a/builtin-commit.c b/builtin-commit.c > > index e88b78f..2d90f74 100644 > > --- a/builtin-commit.c > > +++ b/builtin-commit.c > > @@ -945,6 +945,9 @@ int cmd_commit(int argc, const char **argv, const char *prefix) > > > > git_config(git_commit_config, NULL); > > > > + if (wt_status_use_color == -1) > > + wt_status_use_color = git_use_color_default; > > + > > argc = parse_and_validate_options(argc, argv, builtin_commit_usage, prefix); > > > > index_file = prepare_index(argc, argv, prefix); > > My first reaction was: > > When the editor does get launched, what would the new code do with > your patch? Would we see bunch of escape codes in the editor now? > > But we do disable color explicitly when we generate contents to feed the > editor in that case since bc5d248 (builtin-commit: do not color status > output shown in the message template, 2007-11-18), so that fear is > unfounded. I had the same reaction, so I would like to see this reasoning in the commit message. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
