On Wed, Jan 07, 2009 at 11:27:54AM +0000, Kirill Smelkov wrote:
> Martin, thanks for your review.
>
> I'll too reply inline:
>
> On Tue, Jan 06, 2009 at 09:32:03PM +0100, martin f krafft wrote:
> > Thanks, Kirill, for the patches. A couple of comments inline. I hope
> > Petr has a chance to look too.
> >
> > also sprach Kirill Smelkov <kirr@xxxxxxxxxxxxxxxxxxx> [2009.01.06.1616 +0100]:
> > > +# isatty FD
> > > +isatty()
> > > +{
> > > + tty -s 0<&$1 || return 1
> > > + return 0
> > > +}
> >
> > You don't need any of the return statements. Functions' return
> > values are the return values of the last commands they execute.
>
> Agree, I'll rework isatty to be just
>
> isatty()
> {
> tty -s 0<&$1
> }
why not test -t 0 ? I'm not sure it's POSIX though.
--
·O· Pierre Habouzit
··O madcoder@xxxxxxxxxx
OOO http://www.madism.org
Attachment:
pgpPB8CN05zhU.pgp
Description: PGP signature
