Kjetil Barvik <barvik@xxxxxxxxxxxx> writes: > Start using the optimised, faster and more effective symlink/directory > cache. The previously used call: > > has_symlink_leading_path(len, name); > > should be identically with the following call to lstat_cache(): > > lstat_cache(len, name, > LSTAT_SYMLINK|LSTAT_DIR, > LSTAT_SYMLINK); > ... Care to enlighten why some of callers use the above, but not others? Namely, check_removed() in diff-lib.c and callers in unpack-trees.c care about NOTDIR unlike others, even though the original code checked for exactly the same condition. Does this mean that some callers of has_symlink_leading_path() checked only for leading symlinks when they should also have checked for a leading non-directory, and this patch is also a bugfix? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
