2009/1/3 Matt Kraai <kraai@xxxxxxxxx>:
[...]
> -sub feature_blame {
> - my ($val) = git_get_project_config('blame', '--bool');
> +sub feature_bool {
> + my $key = shift;
> + my ($val) = git_get_project_config($key, '--bool');
>
> if ($val eq 'true') {
> return 1;
Maybe that should be:
return ($val eq 'true');
as It is not a good idea to use 0 as a replacement for perls false, as
the two have different behaviour.
$perl -wle'my $val=shift; my $x=$val eq "true"; print "<$_>" for $x, 0+$x' false
<>
<0>
Cheers,
yves
--
perl -Mre=debug -e "/just|another|perl|hacker/"
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
