On Thu, Jan 1, 2009 at 5:46 PM, Giuseppe Bilotta <giuseppe.bilotta@xxxxxxxxx> wrote: > Actually, the early bailout was sort of intentional. The problem is > the ambiguity: does git.example.com/opml refer to the opml project, or > does it refer to the opml action? Good point. Though my patch does not break any existing functionality, it does not fix the case where a project matches the action. > HOWEVER, href() *does* create the opml action as git.example.com/opml, > so gitweb is currently broken in the sense that ti doesn't correctly > parse its own pathinfo output. So the question is: shall we go with > this patch, preventing pathinfo from working for projects named like a > no-project gitweb action, or should we fix href() to not generate > pathinfo unless project is defined? A variation of the latter approach is to modify href() to use pathinfo if there is a project or there is no project matching the name of the action. The only downside to this approach is that a URI that refers to an action when first generated could resolve to a project in the future, if a project of the same name were added. -- Devin Doucette -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
