Re: [PATCH] builtin-shortlog.c: use string_list_append() instead of duplicating its code

[Johannes Schindelin <Johannes.Schindelin@xxxxxx>]

Hi,

On Wed, 24 Dec 2008, Adeodato Simó wrote:

> Also, when clearing the "onelines" string lists, do not free the "util"
> member: with string_list_append() is not initialized to any value (and
> was being initialized to NULL previously anyway).
> 
> NB: The duplicated code in builtin-shortlog.c predated the appearance of
> string_list_append().
> 
> Signed-off-by: Adeodato Simó <dato@xxxxxxxxxxxxxx>

FWIW I like the patch, but would like it even more if the strdup() removal 
was squashed in (with an explanation in the commit message).

Ciao,
Dscho