jidanni@xxxxxxxxxxx writes:
> @@ -209 +209 @@ project:
> -$ git format-patch \--root origin
> +$ git format-patch --root origin
I thought these backslashes before double-dash are protecting the latter
from being turned into em-dashes. I do not see any weird backslash in the
"git help" (aka "manpage") output nor in the HTML documentation, e.g.
http://www.kernel.org/pub/software/scm/git/docs/git-format-patch.html
without your patch, so I have to say that this chunk is a useless churn.
All of your three patches lack context, which is essential enabler for
easier review. They have "diff --git" header, but are not made relative
to the root of the project tree (i.e. lack "Documentation/" prefix), which
is the norm for both the tool and for this project and this mailing list.
I guess that you may be experimenting with various options to see how they
work, and the curiosity by itself is a good thing, but please do not make
other people suffer with results from such experiments by sending patches
in nonstandard forms.
By submitting a patch to try improving the system, you are already making
a difference in substance. Please do not try to be creative in form. It
only makes lives of other people unnecessarily harder with no real reason
and wastes other people's time. And it wastes yours, too. A patch
conforming to the norm is much easier to review, comment on and apply.
Ok?
"Don't try to be different in form, make a difference in substance" also
applies to your S-o-b line, by the way.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
