On Thu, Dec 18, 2008 at 7:15 PM, Jakub Narebski <jnareb@xxxxxxxxx> wrote: > > Just a though, but does it really take much sense to have "patch" and > "patches" views handled in git_commitdiff? I can understand in the > first version, where it was more about better 'commitdiff_plain', but > I wonder about now, where patch(es) view is something between git show > and log_plain format... Wouldn't it be simpler to use separate > subroutine, for example git_format_patch or something? I don't feel like much has changed since the beginning when IYO it made sense to have it part of commitdiff, honestly -- Giuseppe "Oblomov" Bilotta -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html