On Thu, 18 Dec 2008, René Scharfe wrote:
>
> Yes, but now I get two new warnings:
>
> diff.c: In function `diff_populate_filespec':
> diff.c:1809: warning: passing arg 2 of `sha1_object_info' from
> incompatible pointer type
> diff.c:1811: warning: passing arg 3 of `read_sha1_file' from
> incompatible pointer type
Yeah, yeah, we should probably fix it all, but you're right, your patch
avoids the pain.
The good news is that "size_t" and "unsigned long" really are the same
size on all sane platforms. You'll see differences just in the odd 16-bit
world ("small" memory model with 16-bit size_t and possibly 32-bit "long")
Although I guess some really odd more modern case might have a 32-bit
pointer (and size_t) and 64-bit long. If it's possible to screw the type
system up, history shows that somebody (usually Windows) will do it.
Linus
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
