On Thu, Dec 18, 2008 at 04:53:42AM +0800, jidanni@xxxxxxxxxxx wrote: > I'm still reading the manpage about submitting proper patches, so for now: It looks like you didn't even use git to create it (since it is a context diff and the filenames are obviously bogus). If you are committed to improving git, then surely using it is not so bad? :) Try cloning git://git.kernel.org/pub/scm/git/git.git, or if you just have a tarball, at least do "cd /path/to/git && git init && git add . && git commit -m 'import from git version $whatever'". Then you can make your changes and have git track them and prepare them for submission. Then read Documentation/SubmittingPatches, which covers some of the basics. Besides the format not being applicable by regular git tools: - there is no commit message describing the changes, nor the reasoning behind them - it was not sent to the maintainer (who does read the list, but does not always read every message). > --in-reply-to=Message-Id:: > Make the first mail (or all the mails with --no-thread) appear as a > reply to the given Message-Id, which avoids breaking threads to > ! provide a new patch series. Generates coresponding References and > ! In-Reply-To headers. Angle brackets around <Message-Id> are optional. As for the change itself, it looks reasonable to me. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
