On Wed, 17 Dec 2008, Junio C Hamano wrote: > - result[len] = 0; > + result_size = buf.len; > + result = strbuf_detach(&buf, NULL); If result_size was made size_t, this would be result = strbuf_detach(&buf, &result_size); But whether it makes any difference, I dunno. Anyway, Ack on the 6-8 additions. Linus -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html