On Friday 2008 December 12 22:43:57 Josef Jeff Sipek wrote:
>> + if [ -n "$5" -o "x$diffstat" = "x1" ]; then
>
>Why the 'x' thing? I've seen it is some scripts before, but I can't think of
>a reason to use it if the variable is surrounded in quotation marks.
'[' or test see the arguments after they are unquoted (normally). So,
if "$diffstat" is "-n" it might try and do the -n test, rather than the =
test.
It could be re-written as "1" == "${diffstat}" instead to avoid the x, but
it's not a big deal (to me). That also looks backwards to a lot of people.
--
Boyd Stephen Smith Jr. ,= ,-_-. =.
bss03@xxxxxxxxxxxxxx ((_/)o o(\_))
ICQ: 514984 YM/AIM: DaTwinkDaddy `-'(. .)`-'
http://iguanasuicide.org/ \_/
Attachment:
signature.asc
Description: This is a digitally signed message part.
