>From 507442611386c29c9b91d3eb4bb0a69a383dc409 Mon Sep 17 00:00:00 2001 From: Sebastien Cevey <seb@xxxxxxxxx> Date: Thu, 4 Dec 2008 00:24:12 +0100 To: git@xxxxxxxxxxxxxxx CC: Junio C Hamano <gitster@xxxxxxxxx>, Petr Baudis <pasky@xxxxxxx>, Gustavo Sverzut Barbieri <barbieri@xxxxxxxxxxxxxx>, seb@xxxxxxxxx Subject: [PATCH v4 1/3] gitweb: Modularized git_get_project_description to be more generic User-Agent: Wanderlust/2.14.0 (Africa) X-Message-Flag: OUTLOOK ERROR: Large chicken feathers stuck in power supply fan. Introduce a git_get_file_or_project_config utility function to retrieve a repository variable either from a plain text file in the $GIT_DIR or else from 'gitweb.$variable' in the repository config (e.g. 'description'). Signed-off-by: Sebastien Cevey <seb@xxxxxxxxx> --- Identical to the previous version. gitweb/gitweb.perl | 24 ++++++++++++++++-------- 1 files changed, 16 insertions(+), 8 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 6eb370d..f7dc337 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -2020,18 +2020,26 @@ sub git_get_path_by_hash { ## ...................................................................... ## git utility functions, directly accessing git repository -sub git_get_project_description { - my $path = shift; +# get the value of a config variable either from a file with the same +# name in the repository, or the gitweb.$name value in the repository +# config file. +sub git_get_file_or_project_config { + my ($name, $path) = @_; $git_dir = "$projectroot/$path"; - open my $fd, "$git_dir/description" - or return git_get_project_config('description'); - my $descr = <$fd>; + open my $fd, "$git_dir/$name" + or return git_get_project_config($name); + my $conf = <$fd>; close $fd; - if (defined $descr) { - chomp $descr; + if (defined $conf) { + chomp $conf; } - return $descr; + return $conf; +} + +sub git_get_project_description { + my $path = shift; + return git_get_file_or_project_config('description', $path); } sub git_get_project_ctags { -- 1.5.6.5 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html