James Youngman wrote: > On Thu, Dec 11, 2008 at 9:06 PM, Brandon Casey <casey@xxxxxxxxxxxxxxx> wrote: >> James Youngman wrote: >>> What do the errors "error: char88: malformed tagger field" and "fatal: >>> invalid tag signature file" and "Could not create new tag object for >>> FINDUTILS-4_1-10" signify in the session below? >> It means the tagger field in the tag does not follow the correct form. >> Specifically the testing in git-mktag (called by filter-branch) does: >> >> * Check for correct form for name and email >> * i.e. " <" followed by "> " on _this_ line >> * No angle brackets within the name or email address fields. >> * No spaces within the email address field. >> >> What does 'git cat-file tag FINDUTILS-4_1-10' show you? > > Before conversion: > $ git cat-file tag FINDUTILS-4_1-10 > object ce25eb352de8dc53a9a7805ba9efc1c9215d28c2 > type commit > tag FINDUTILS-4_1-10 > tagger Kevin Dalley The tagger field is missing an email address, a timestamp, and a timezone. It should look something like: tagger Kevin Dalley <kevin.dalley@xxxxxxxxxxxxx> 1229036026 -0800 git-mktag prevents improperly formatted tags from being created by checking that these fields exist and are well formed. If you know the correct values for the missing fields, then you could recreate the tags before doing the filter-branch. If they are unknown, it seems valid enough to use the values from the commit that the tag points to. i.e. tagger Kevin Dalley <kevin@xxxxxxxx> 830638152 -0000 What tool was used to convert this repository to git? It should be corrected to produce valid annotated tags. Especially if it is a tool within git. The tag below was actually not converted. filter-branch bailed out during the conversion and so left it alone. > The conversion: > > After conversion: > $ git cat-file tag FINDUTILS-4_1-10 > object ce25eb352de8dc53a9a7805ba9efc1c9215d28c2 > type commit > tag FINDUTILS-4_1-10 > tagger Kevin Dalley > > This is in the repo at > http://git.savannah.gnu.org/gitweb/?p=findutils.git;a=commit;h=ce25eb352de8dc53a9a7805ba9efc1c9215d28c2 -brandon -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
