Luben Tuikov <ltuikov@xxxxxxxxx> writes: > --- On Wed, 12/10/08, Jakub Narebski <jnareb@xxxxxxxxx> wrote: >> Acked-by: Luben Tuikov <ltuikov@xxxxxxxxx> >> Signed-off-by: Jakub Narebski <jnareb@xxxxxxxxx> > > I've always seen "Acked-by:" follows "Signed-off-by:". Junio, has this > changed? I think the order is supposed to show the order of things happened. Jakub signs off the patch, you Ack, and I see the patch and append my sign-off. You saw the exact same patch text, said that looked Ok to you, and Jakub updated the log message to present the change better and signed off the whole thing again. You could say that there should be another, original, sign off by Jakub before your Ack, but I do not think it adds anything of value. In any case, the change will be queued to 'pu'. It is great that it is a trivial change that gives us great performance boost, and I wish all our patches are like that ;-). -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
